Re: Clearly setting apart the code we want to replace?

On Sun, Oct 16, 2016 at 4:27 PM, Erik Huelsmann <..hidden..> wrote:

Hi all,

The source code in our project falls into two categories:

1. the code we newly wrote (and which we want to maintain)
2. the code that we inherited (and which we want to replace)

Where to find code of the first and the second category, is pretty clear to most of us. However, it's not to any new-comers to the project.
In order to improve this clarity - making it easier to communicate about it - I'm proposing to move all *library* code that we intend to replace from lib/ to old/, meaning

* lib/LedgerSMB/??.pm -> old/LedgerSMB/??.pm
* lib/LedgerSMB/PriceMatrix.pm -> old/LedgerSMB/
* lib/LedgerSMB/Form.pm -> old/LedgerSMB/
* lib/LedgerSMB/Num2text.pm -> old/LedgerSMB/
* lib/LedgerSMB/Session.pm -> old/LedgerSMB/
* lib/LedgerSMB/old_code.pm -> old/LedgerSMB/
* lib/LedgerSMB/PGOld.pm -> old/LedgerSMB/

While I'm aware we didn't inherit PGOld, but I think it's code we want to phase out anyway.

This (lib/ -> old/lib/) and moving the content of bin/ to old/bin/ has now been done.

Thanks for the feedback!

Bye,

Erik.

http://efficito.com -- Hosted accounting and ERP.

Robust and Flexible. No vendor lock-in.