Clearly setting apart the code we want to replace?

Hi all,

The source code in our project falls into two categories:

1. the code we newly wrote (and which we want to maintain)

2. the code that we inherited (and which we want to replace)

Where to find code of the first and the second category, is pretty clear to most of us. However, it's not to any new-comers to the project.

In order to improve this clarity - making it easier to communicate about it - I'm proposing to move all *library* code that we intend to replace from lib/ to old/, meaning

* lib/LedgerSMB/??.pm -> old/LedgerSMB/??.pm

* lib/LedgerSMB/PriceMatrix.pm -> old/LedgerSMB/

* lib/LedgerSMB/Form.pm -> old/LedgerSMB/

* lib/LedgerSMB/Num2text.pm -> old/LedgerSMB/

* lib/LedgerSMB/Session.pm -> old/LedgerSMB/

* lib/LedgerSMB/old_code.pm -> old/LedgerSMB/

* lib/LedgerSMB/PGOld.pm -> old/LedgerSMB/

While I'm aware we didn't inherit PGOld, but I think it's code we want to phase out anyway.

(Note that the above only applies to current master, meaning 1.6+)

Furher more, I'd like to remove the REST_Class::* and REST_Format::* handlers, as they apply to REST services which we never really supported.

If we do things this way, then there are 2 directories with code we want to "dump": bin/ and old/. I think that concept is quite easy to explain.

Comments?

Regards,

Bye,

Erik.

http://efficito.com -- Hosted accounting and ERP.

Robust and Flexible. No vendor lock-in.