The first thing that came to mind while reading this was the Dancer path structure. So I came to the same conclusion as Erik, we should design it and then move the files to proper locations, otherwise there will be work duplication.
We do have files that are really static and could be served as is and other for which Templating is required. The structure should facilitate handling both cases by the appliaction and the developers
Le 2017-08-12 à 10:42:13, Erik Huelsmann a écrit :
On Sat, Aug 12, 2017 at 10:48 AM, David G <..hidden..> wrote:
I agree that a better organization of files in the UI subtree would be desirable.
I haven't gone for a specific look yet, but I'm envisaging a dir tree that closely matches the "functional" use of each levels content.
so something loosely along the lines of....
Hmm. It seems we roughly have something like that, but not quite: your grouping puts the files which are part of the "main" application into the UI/app/ directory. Our current "LedgerSMB/Scripts/" directory doesn't group them that way. Your further ordering is by module which uses them. That seems to be in line with our current directory layout, with the exception of the Reports/ hierarchy which collects all reports across function-areas.
Thinking about this more, I come to the conclusion it probably has a lot to do with how we structure our tree when switching to Dancer with nice URLs and routes. We'd probably want to have a directory structure which closely resembles the URI structure for the routes we'll be creating.
Considering the above, I'm thinking that short-term I made an improvement by deleting 16 unused files (see below) and that we can delete 3 more unreferenced ones (UI/info.html, UI/approved.html and UI/corrections.html and 7 more (UI/am-*.html) by moving am.pl onto new code and LedgerSMB::Report.
Other than that, we may need to look at the structure more when we're going to re-arrange the tree when moving more to Dojo, Dancer and Services.
Note that I've just merged a PR which deletes 16 unused files in total, 12 from the top-level UI/ directory, which cleans things up quite a bit (many of the deleted files were used by now-removed old/bin/*.pl modules).
______________________________On 11/08/17 22:34, Erik Huelsmann wrote:
_________________ devel mailing list ..hidden.. https://lists.ledgersmb.org/ma ilman/listinfo/devel
devel mailing list
_________________ devel mailing list ..hidden.. https://lists.ledgersmb.org/ mailman/listinfo/devel
devel mailing list
_______________________________________________ devel mailing list ..hidden.. https://lists.ledgersmb.org/mailman/listinfo/devel