LedgerSMB
The foundation for your business
Fork me on GitHub
Re: [ledgersmb-devel] [devel] Turning off Coveralls commenting on PRs?
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ledgersmb-devel] [devel] Turning off Coveralls commenting on PRs?



I'm happy with making this change.
The information is certainly available without the comments.


On 05/08/17 16:25, Erik Huelsmann wrote:
Hi,

Currently, all PRs are tested by Coveralls and Travis CI. Travis CI doesn't comment on our PRs, but Coveralls does. Initially, maybe, there wasn't a good way for Coveralls to indicate success/failure otherwise. However, since both Coveralls and Travis have the "tests in progress" section on the PR, every PR will show the latest Coveralls state right above the merge button.

So, I propose we stop Coveralls from generating these comments.

Anybody who does want the Coveralls notifications would need to create a coveralls account, add the LedgerSMB repo to his account and set up e-mail notification. With that, you'll receive mail notification of every Travis CI build with coverage information.

If no objections by the end of Sunday, I'll modify the settings in Coveralls accordingly.

--
Bye,

Erik.

http://efficito.com -- Hosted accounting and ERP.
Robust and Flexible. No vendor lock-in.


_______________________________________________
devel mailing list
..hidden..
https://lists.ledgersmb.org/mailman/listinfo/devel

_______________________________________________
devel mailing list
..hidden..
https://lists.ledgersmb.org/mailman/listinfo/devel