[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: After Dojo widgets tree reorg, now move ./LedgerSMB* into ./lib/*?




On Mar 1, 2016 2:48 PM, "Erik Huelsmann" <..hidden..> wrote:
>
> Hi Chris,
>
> If we make this conditional on the merge of the MC branch, then an important question is if we have an outlook as to the solution of the required data migration from non-MC to MC. As long as we don't have a good solution there, I'm thinking we shouldn't hold back changes conditionally.
>
> I'd like to put it differently: if we postpone this until after 1.5 then is there a good reason why we would *not* want to have this in 1.5 whereas that reason doesn't apply to 1.6?

I am worried about tests and tooling.

> If this really is about merging pain, then I'm thinking we should create a copy-repo, create the move on master and then try to merge that to MC and see if it works or completely falls down. Does that work for you?

Yes that is fine.   Might also be worth playing with in a branch for discussion and review purposes
>
>
> Regards,
>
> Erik.
>
>
> On Thu, Feb 25, 2016 at 8:03 AM, Chris Travers <..hidden..> wrote:
>>
>> Would recommend right after branching 1.5.  The reason is this gives more time to make sure our tooling works.  And we could merge the multicurrency branch immediately before.
>>
>>
>>
>> On Mon, Feb 22, 2016 at 6:21 PM, Erik Huelsmann <..hidden..> wrote:
>>>
>>> Hi all,
>>>
>>> In the past we've always said we want our tree structure to be compatible with the requirements for CPAN. With our recent cleanup, it looks like the next step is really, really close: to me it looks like all we need to do is move LedgerSMB* from the toplevel directory into a newly created 'lib/' directory.
>>>
>>> There's never a truely good time to refactor source trees while there are old maintenance lines, but with the recent refactoring, it seems like "now" would be a good time for renaming the Perl library directories too, right?
>>>
>>>
>>>
>>> --
>>> Bye,
>>>
>>> Erik.
>>>
>>> http://efficito.com -- Hosted accounting and ERP.
>>> Robust and Flexible. No vendor lock-in.
>>
>>
>>
>>
>> --
>> Best Wishes,
>> Chris Travers
>>
>> Efficito:  Hosted Accounting and ERP.  Robust and Flexible.  No vendor lock-in.
>> http://www.efficito.com/learn_more
>
>
>
>
> --
> Bye,
>
> Erik.
>
> http://efficito.com -- Hosted accounting and ERP.
> Robust and Flexible. No vendor lock-in.

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Ledger-smb-devel mailing list
..hidden..
https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel