Re: More conservative screen-width use in Payments screen?

[herman vierendeels <..hidden..>]

Hi Erik,

As i see it , you would like to use shorter names. e.g 'Amount Due' -> 'Due'
But why not use  locale/po/en.po to get shorter names?
e.g.
msgid "Amount Due"
msgstr "Due"

msgid  'Due' is nearly intranslatable without context. It could be
'Amount Due','Date Due' etc.

Best Wishes,
Herman

2011/12/27 Erik Huelsmann <..hidden..>:
> Hi,
>
> Today the fact that the dates in my Payments screen line-wrap
> irritated enough to create the patch below. I know Herman worked on
> translations, so I'd like to send it in for review before I commit it.
>
> Comments? Can I commit?
>
> Index: scripts/payment.plmb# has nothing to do with the payment you're entering,
> ===================================================================
> --- scripts/payment.pl  (revision 4243)
> +++ scripts/payment.pl  (working copy)
> @@ -884,18 +884,18 @@
>  my $default_currency_text = $currency_text ? '('.$default_currency.')' : '';
>  my @column_headers =  ({text => $locale->text('Invoice')},
>                        {text => $locale->text('Date')},
> -                       {text => $locale->text('Total').$default_currency_text},
> -                       {text => $locale->text('Paid').$default_currency_text},
> -                       {text =>
> $locale->text('Discount').$default_currency_text},
> +                       {text => $locale->text('Total
> ').$default_currency_text},
> +                       {text => $locale->text('Paid ').$default_currency_text},
> +                       {text => $locale->text('Discount
> ').$default_currency_text},
>                        {text => $locale->text('Apply Disc')},
>                        {text => $locale->text('Memo')},
> -                       {text => $locale->text('Amount
> Due').$default_currency_text}
> +                       {text => $locale->text('Due ').$default_currency_text}
>                        );
>  # WE NEED TO KNOW IF WE ARE USING A CURRENCY THAT NEEDS AN EXCHANGERATE
>  if ($default_currency ne $request->{curr} ) {
>  # FIRST WE PUSH THE OTHER COLUMN HEADERS WE NEED
> -     push @column_headers, {text => $locale->text('Exchange Rate')},
> -                           {text => $locale->text('Amount
> Due').$currency_text};
> +     push @column_headers, {text => $locale->text('FX Rate')},
> +                           {text => $locale->text('Due ').$currency_text};
>  # WE SET THEM IN THE RIGHT ORDER FOR THE TABLE INSIDE THE UI
>      @column_headers[7,8] = @column_headers[8,7];
>  # DOES THE CURRENCY IN USE HAS AN EXCHANGE RATE?, IF SO
>
>
> Bye,
>
>
> Erik.
>
> ------------------------------------------------------------------------------
> Write once. Port to many.
> Get the SDK and tools to simplify cross-platform app development. Create
> new or port existing apps to sell to consumers worldwide. Explore the
> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> http://p.sf.net/sfu/intel-appdev
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel