[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 1.3.10-RC1 fx-payments issue(s)

> While testing 1.3.10-rc1, we found a few issues:
> 1. The function Payment.sql:payment_post() posts the FX gains/losses
> for vendors with the wrong sign (positive in case of gain and negative
> in case of loss, instead of the other way around)

Because I needed the functionality ASAP myself, I've been working on
this issue today and I think I have it fixed now in the 1.3 branch.
Testing would of course be much appreciated.

> 2. The Payment.sql:payment_post() function uses the
> 'FX_gain'/'FX_loss' configuration key to identify the account to post
> fx gains/losses to. However, none of the default CoA files define that
> key
> 3. It looks to me like the system used to use 'fxgain_accno_id' and
> fxloss_accno_id' configuration keys to indicate the fx gains/losses
> accounts. These keys still occur throughout our Perl code (am.pl,
> AA.pm, AM.pm, IR.pm, IS.pm, account.pl)

So far I didn't do anything about these: I have no idea whatsoever
about the direction a fix should go here: is the FX_gain/FX_loss the
new direction and just not replaced everywhere? If so, why is that? To
me it seems nice to be able to select an ID from the defaults table
instead of being required to join the defaults table with the accounts
table on the default.value column!

That's my progress of the moment. There's not much more I can do at this moment.