Re: Recommend we don't support users running built dojo on a git/hg/svn branch

[Chris Travers <..hidden..>]

On Sat, Jul 30, 2016 at 2:20 PM, David G <..hidden..> wrote:
> Hi Chris,
>
> In the past I would have to have agreed with you, however, in the last few
> days, ylavoie (irc/matrix) has  implemented a git based technique to handle
> correct rebuilding of dojo only when needed for the travis tests.
>
> I believe the "exact" same technique can be used to resolve the issue on
> production installations as well.
> However in a production environment, rather than "automatically" rebuilding,
> we can simply block login at the login page with a message that dojo modules
> need to be rebuilt.

Also aside from the fact that our build process should not be based on
whatever version control software someone happens to be using, would
it not make a lot more sense to just note in the log that dojo might
need to be rebuilt and that performance will suffer and fail back to
using non-built?
>
> This actually fits in with some other changes I have planned for the login
> screen over the next 7 days, so I'll take ownership and prepare a PR that
> covers this as well.
>
> Regards
> David G
>
>
>
> On 29/07/16 00:16, Chris Travers wrote:
>
> Hi;
>
> I spent a fair bit of time troubleshooting a bug that turned out to be a
> missing make dojo step.  I know the user who reported it had trouble with
> the make dojo step and it didn't seem like a widget bug to me until I got
> fairly deep into it.
>
> In the past we have supported people running LedgerSMB directly out of code
> repos or checkouts.  I think we should continue to do that, but we really
> cannot guarantee that dojo gets rebuilt every time it should in these cases,
> so I think we should explicitly say that running with built dojo on a branch
> (stable or not) is not supported.
>
> The built dojo strikes me as mostly useful when people are installing from
> packages and so we are providing the built libraries.  But if we aren't
> providing the built libraries, then we can't be sure which versions they are
> using.
>
> As a side note, i think we also need to really carefully think about how we
> can properly handle cache invalidation in our current approach.
>
> Unless there are any objections, I will put a note saying that running with
> dojo_built=1 from git, hg, svn, etc is unsupported.  I think that will avoid
> a lot of effort on our part and a lot of headache for would-be users.
>
> --
> Best Wishes,
> Chris Travers
>
> Efficito:  Hosted Accounting and ERP.  Robust and Flexible.  No vendor
> lock-in.
> http://www.efficito.com/learn_more
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>

------------------------------------------------------------------------------
_______________________________________________
Ledger-smb-devel mailing list
..hidden..
https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel