[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug/Patch: email form not populated with emails from account



Hi John,

I've isolated the error checking and typo correction into separate
commits (r3321 and r3320 respectively).

While I do agree that your change is desirable (a lot), I also think
it's incomplete: For physical addresses, we distinguish billing and
sales addresses. I think we should do the same for e-mail addresses.
Then, if there's no billing e-mail, we use the normal e-mail. CC and
BCC are only added if there are explicit CC and BCCs for billing.

Agreed?

Regards,

Erik.


On Sun, Jun 19, 2011 at 5:16 PM, John Locke <..hidden..> wrote:
> When using the "Email" button to send an invoice to a customer, the
> email form does not populate the email/cc/bcc fields from the customer
> account.
>
> Here's at least a partial patch to accomplish this (partial because I'm
> not sure if I have all of the areas I patched to make this happen -- it
> does work correctly on my system.). This patch is against svn #3281, let
> me know if I need to re-roll against an updated trunk.
>
> Cheers,
> John Locke
> http://freelock.com
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>
>