[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

SF.net SVN: ledger-smb:[6401] trunk



Revision: 6401
          http://sourceforge.net/p/ledger-smb/code/6401
Author:   einhverfr
Date:     2014-01-06 07:53:06 +0000 (Mon, 06 Jan 2014)
Log Message:
-----------
Removing more commits

Modified Paths:
--------------
    trunk/LedgerSMB/AM.pm
    trunk/LedgerSMB/Business_Unit_Class.pm
    trunk/LedgerSMB/DBObject/Asset.pm
    trunk/LedgerSMB/DBObject/Asset_Class.pm
    trunk/LedgerSMB/DBObject/Draft.pm
    trunk/LedgerSMB/DBObject/EOY.pm
    trunk/LedgerSMB/DBObject/Location.pm
    trunk/LedgerSMB/DBObject/Pricelist.pm
    trunk/LedgerSMB/DBObject/TaxForm.pm
    trunk/LedgerSMB/DBObject/TransTemplate.pm
    trunk/LedgerSMB/DBObject/User.pm
    trunk/LedgerSMB/File/ECA.pm
    trunk/LedgerSMB/File/Entity.pm
    trunk/LedgerSMB/File/Order.pm
    trunk/LedgerSMB/File/Part.pm
    trunk/LedgerSMB/File/Transaction.pm
    trunk/LedgerSMB/File.pm
    trunk/LedgerSMB/Form.pm
    trunk/LedgerSMB/GL.pm
    trunk/LedgerSMB/IC.pm
    trunk/LedgerSMB/IR.pm
    trunk/LedgerSMB/OE.pm
    trunk/LedgerSMB/Session.pm
    trunk/lsmb-request.pl

Modified: trunk/LedgerSMB/AM.pm
===================================================================
--- trunk/LedgerSMB/AM.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/AM.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -106,7 +106,6 @@
         $form->{orphaned} = 0;
     }
 
-    $dbh->commit;
 
 }
 
@@ -154,7 +153,6 @@
     $sth = $dbh->prepare($query);
     $sth->execute(@queryargs) || $form->dberror($query);
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -181,7 +179,6 @@
     $sth = $dbh->prepare($query);
     $sth->execute( $form->{id} ) || $form->dberror($query);
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -230,7 +227,6 @@
         $form->{orphaned} = 0;
     }
 
-    $dbh->commit;
 }
 
 =item AM->save_warehouse($myconfig, $form);
@@ -272,7 +268,6 @@
     $sth = $dbh->prepare($query);
     $sth->execute(@queryargs) || $form->dberror($query);
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -296,7 +291,6 @@
 		      WHERE id = ?|;
 
     $dbh->prepare($query)->execute( $form->{id} ) || $form->dberror($query);
-    $dbh->commit;
 
 }
 
@@ -324,7 +318,6 @@
     $sth = $dbh->prepare($query);
     $sth->execute( $form->{id} );
     ( $form->{description}, $form->{discount} ) = $sth->fetchrow_array();
-    $dbh->commit;
 
 }
 
@@ -375,7 +368,6 @@
         $sth->execute();
         ($form->{id}) = $sth->fetchrow_array;
     }
-    $dbh->commit;
 
 }
 
@@ -398,7 +390,6 @@
 		      WHERE id = ?|;
 
     $dbh->prepare($query)->execute( $form->{id} ) || $form->dberror($query);
-    $dbh->commit;
 
 }
 
@@ -443,7 +434,6 @@
     }
 
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -476,7 +466,6 @@
     for ( keys %$ref ) { $form->{$_} = $ref->{$_} }
 
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -522,7 +511,6 @@
     }
 
     $dbh->prepare($query)->execute(@queryargs) || $form->dberror($query);
-    $dbh->commit;
 
 }
 
@@ -545,7 +533,6 @@
 		      WHERE code = ?|;
 
     $dbh->prepare($query)->execute( $form->{code} );
-    $dbh->commit;
 
 }
 
@@ -578,7 +565,6 @@
     for ( keys %$ref ) { $form->{$_} = $ref->{$_} }
 
     $sth->finish;
-    $dbh->commit;
 
 }
 
@@ -625,7 +611,6 @@
     }
 
     $dbh->prepare($query)->execute(@queryargs) || $form->dberror($query);
-    $dbh->commit;
 
 }
 
@@ -871,7 +856,6 @@
         chop $form->{transactions}{$transaction}->[$i]->{recurringprint};
     }
 
-    $dbh->commit;
 
 }
 
@@ -977,7 +961,6 @@
     for (qw(arinvoice apinvoice invnumber)) { delete $form->{$_} }
     
 
-    $dbh->commit;
 
 }
 
@@ -1029,7 +1012,6 @@
 
     $dbh->do($query) || $form->dberror($query);
 
-    $dbh->commit;
 
 }
 
@@ -1134,7 +1116,6 @@
 
     $sth->finish;
 
-    $dbh->commit;
 
 }
 
@@ -1200,9 +1181,8 @@
        $sth->finish;
     }
 
-    my $rc = $dbh->commit;
 
-    $rc;
+    1;
 
 }
 

Modified: trunk/LedgerSMB/Business_Unit_Class.pm
===================================================================
--- trunk/LedgerSMB/Business_Unit_Class.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/Business_Unit_Class.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -109,7 +109,7 @@
     $self->save_modules();
     $self->prepare_dbhash($ref);
     $self = $self->new(%$ref);
-    $self->dbh->commit;
+    return $self;
 }   
 
 =item save_modules

Modified: trunk/LedgerSMB/DBObject/Asset.pm
===================================================================
--- trunk/LedgerSMB/DBObject/Asset.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/Asset.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -105,11 +105,7 @@
     my ($self) = @_;
     my ($ref) = $self->exec_method(funcname => 'asset__save');
     $self->merge($ref);
-    $self->{dbh}->commit || $self->error(
-                  $self->{_locale}->text("Unable to save [_1] object", 
-                          $self->{_locale}->text('Asset'))
-    );
-    return $ref if $self->{dbh}->commit;
+    return $ref;
 }
 
 =item import_file
@@ -213,7 +209,6 @@
 sub save_note {
     my ($self) = @_;
     my ($ref) = $self->exec_method(funcname => 'asset_item__add_note');
-    $self->{dbh}->commit;
 }
 
 =item get_metadata
@@ -271,7 +266,6 @@
           args     => ['asset_tag']
     );
     $self->{tag} = $ref->{setting_increment};
-    $self->{dbh}->commit;
 }
 
 =item import_asset

Modified: trunk/LedgerSMB/DBObject/Asset_Class.pm
===================================================================
--- trunk/LedgerSMB/DBObject/Asset_Class.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/Asset_Class.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -62,11 +62,7 @@
     my ($self) = @_;
     my ($ref) = $self->exec_method(funcname => 'asset_class__save');
     $self->merge($ref);
-    $self->{dbh}->commit || $self->error(
-                  $self->{_locale}->text("Unable to save [_1] object", 
-                          $self->{_locale}->text('Asset Class'))
-    );
-    return $ref if $self->{dbh}->commit;
+    return $ref;
 }
 
 =item get_metadata 

Modified: trunk/LedgerSMB/DBObject/Draft.pm
===================================================================
--- trunk/LedgerSMB/DBObject/Draft.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/Draft.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -56,7 +56,6 @@
        $self->error($self->{_locale}->text('No ID Set'));
    }
    ($self->{approved}) = $self->exec_method(funcname => 'draft_approve');
-   $self->{dbh}->commit;
    return $self->{approved};
 }
 
@@ -75,7 +74,6 @@
        $self->error($self->{_locale}->text('No ID Set'));
    }
    ($self->{deleted}) = $self->exec_method(funcname => 'draft_delete');
-   $self->{dbh}->commit;
    return $self->{deleted};
 }
 

Modified: trunk/LedgerSMB/DBObject/EOY.pm
===================================================================
--- trunk/LedgerSMB/DBObject/EOY.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/EOY.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -45,7 +45,6 @@
 sub checkpoint_only {
     my ($self) = @_;
    $self->exec_method(funcname => 'eoy_create_checkpoint');
-   $self->{dbh}->commit;
 }
 
 =item $eoy->reopen_books()
@@ -58,7 +57,6 @@
 sub reopen_books {
     my ($self) = @_;
    $self->exec_method(funcname => 'eoy__reopen_books_at');
-   $self->{dbh}->commit;
 }
 
 =item $eoy->latest_closing()
@@ -85,7 +83,6 @@
 sub close_books {
     my ($self) = @_;
    $self->exec_method(funcname => 'eoy_close_books');
-   $self->{dbh}->commit;
 }
 
 =item $eoy->list_earnings_accounts

Modified: trunk/LedgerSMB/DBObject/Location.pm
===================================================================
--- trunk/LedgerSMB/DBObject/Location.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/Location.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -40,7 +40,6 @@
         $self->{old_location_class} || 1 # obviously, country.
     ]);
     $self->{id} = $ret->{$type."__save_location"};
-    $self->{dbh}->commit();
     return $self->{id};
 }
 

Modified: trunk/LedgerSMB/DBObject/Pricelist.pm
===================================================================
--- trunk/LedgerSMB/DBObject/Pricelist.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/Pricelist.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -53,7 +53,6 @@
         $line->merge($ref);
         $line->exec_method({funcname => 'pricelist__save'});
     }
-    $self->{dbh}->commit;
 }
 
 =back

Modified: trunk/LedgerSMB/DBObject/TaxForm.pm
===================================================================
--- trunk/LedgerSMB/DBObject/TaxForm.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/TaxForm.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -55,7 +55,6 @@
     my ($ref) = $self->exec_method(funcname => 'tax_form__save');
     $self->{taxform_id} = $ref->{'tax_form__save'};
   
-    $self->{dbh}->commit();
 }
 
 =item get($id)

Modified: trunk/LedgerSMB/DBObject/TransTemplate.pm
===================================================================
--- trunk/LedgerSMB/DBObject/TransTemplate.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/TransTemplate.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -31,7 +31,6 @@
        $self->exec_method(funcname => 'journal__save_recurring');
        $self->exec_method(funcname => 'journal__save_recurring_print');
    }
-   $self->{dbh}->commit;
 }
 
 sub search {

Modified: trunk/LedgerSMB/DBObject/User.pm
===================================================================
--- trunk/LedgerSMB/DBObject/User.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/DBObject/User.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -49,7 +49,6 @@
 sub save_preferences {
     my ($self) = @_;
     $self->exec_method(funcname => 'user__save_preferences');
-    $self->{dbh}->commit;
     $self->get_user_info;
 }
 
@@ -79,7 +78,7 @@
     }
     $self->{password} = $self->{new_password};
     $self->exec_method(funcname => 'user__change_password');
-    $self->{dbh}->commit;
+    $self->{dbh}->commit; # This is needed since it is not the normal DBH!
     $self->{dbh}->disconnect;
     $self->{dbh} = $old_dbh;
 }
@@ -301,12 +300,9 @@
         );
     }
     print STDERR Dumper(\@ret);
-    if ($ret[0]->{person__save_contact} == 1){
-        $self->{dbh}->commit();
+    if ($ret[0]->{person__save_contact} != 1){
+        die "Couldn't save contact...";
     }
-    else{
-        $self->error("Couldn't save contact...");
-    }
     return 1;
 }
 

Modified: trunk/LedgerSMB/File/ECA.pm
===================================================================
--- trunk/LedgerSMB/File/ECA.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File/ECA.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -38,7 +38,6 @@
 sub attach {
     my ($self, $args) = @_;
     $self->exec_method({funcname => 'file__attach_to_eca'});
-    $self->commit unless $args->{no_commit};
 }
 
 =back

Modified: trunk/LedgerSMB/File/Entity.pm
===================================================================
--- trunk/LedgerSMB/File/Entity.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File/Entity.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -38,7 +38,6 @@
 sub attach {
     my ($self, $args) = @_;
     $self->exec_method({funcname => 'file__attach_to_entity'});
-    $self->commit unless $args->{no_commit};
 }
 
 =back

Modified: trunk/LedgerSMB/File/Order.pm
===================================================================
--- trunk/LedgerSMB/File/Order.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File/Order.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -40,7 +40,6 @@
 sub attach {
     my ($self, $args) = @_;
     $self->exec_method({funcname => 'file__attach_to_order'});
-    $self->commit unless $args->{no_commit};
 }
 
 =item attach_all_from_order({id = int})
@@ -56,16 +55,15 @@
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($attach);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
     for my $link ($self->list_links({ref_key => $args->{int}, file_class => 2})){
         next if !($link->{src_class} == 2 || $link->{src_class} == 1);
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($link);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
-    $self->commit;
 }
 
 =item attach_all_from_transaction({id = int})
@@ -82,16 +80,15 @@
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($attach);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
     for my $link ($self->list_links({ref_key => $args->{int}, file_class => 1})){
         next if !($link->{src_class} == 2 || $link->{src_class} == 1);
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($link);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
-    $self->commit;
 }
 
 =back

Modified: trunk/LedgerSMB/File/Part.pm
===================================================================
--- trunk/LedgerSMB/File/Part.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File/Part.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -38,7 +38,6 @@
 sub attach {
     my ($self, $args) = @_;
     $self->exec_method({funcname => 'file__attach_to_part'});
-    $self->commit unless $args->{no_commit};
 }
 
 =back

Modified: trunk/LedgerSMB/File/Transaction.pm
===================================================================
--- trunk/LedgerSMB/File/Transaction.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File/Transaction.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -29,7 +29,7 @@
 
 =over
 
-=item attach([{no_commit => bool}])
+=item attach()
 
 Attaches or links a specific file to the given transaction.
 
@@ -38,7 +38,6 @@
 sub attach {
     my ($self, $args) = @_;
     $self->exec_method({funcname => 'file__attach_to_tx'});
-    $self->commit unless $args->{no_commit};
 }
 
 =item attach_all_from_order({id = int})
@@ -54,16 +53,15 @@
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($attach);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
     for my $link ($self->list_links({ref_key => $args->{int}, file_class => 2})){
         next if $link->{src_class} != 2;
         my $new_link = LedgerSMB::File::Transaction->new();
         $new_link->merge($link);
         $new_link->dbobject($self->dbobject);
-        $new_link->attach({no_commit => 1});
+        $new_link->attach;
     }
-    $self->commit;
 }
 
 =back

Modified: trunk/LedgerSMB/File.pm
===================================================================
--- trunk/LedgerSMB/File.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/File.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -326,17 +326,6 @@
     $self->src_class      ($ref->{src_class}      || $self->src_class);
 }
 
-=item commit()
-
-Returns the value of DBI->commit
-
-=cut
-
-sub commit{
-    my ($self) = @_;
-    return $LedgerSMB::App_State::DBH->commit;
-}
-
 =back
 
 =head1 COPYRIGHT

Modified: trunk/LedgerSMB/Form.pm
===================================================================
--- trunk/LedgerSMB/Form.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/Form.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -1789,7 +1789,6 @@
 		      ) || $self->dberror($query);
 	
 	$sth->finish;
-	$dbh->commit;
 
      
     
@@ -2886,10 +2885,6 @@
     $sth->execute( $self->{id}, $printed, $emailed, $spoolfile,
         $self->{formname} ) || $self->dberror($query);
     $sth->finish;
-    if ($commit){
-        $dbh->commit;
-    }
-
 }
 
 =item $form->save_status();
@@ -2974,7 +2969,6 @@
         $sth->execute( $self->{id}, $printed, $emailed, $formname );
         $sth->finish;
     }
-    $dbh->commit;
 }
 
 =item $form->get_recurring();
@@ -3253,7 +3247,6 @@
             $sth->finish;
         }
     }
-    $dbh->commit;
 
 }
 
@@ -3280,7 +3273,6 @@
 
     my $sth = $dbh->prepare($query);
     $sth->execute( $self->{intnotes}, $self->{id} ) || $self->dberror($query);
-    $dbh->commit;
 }
 
 =item $form->update_defaults($myconfig, $fld[, $dbh [, $nocommit]);
@@ -3464,8 +3456,6 @@
     $sth = $self->{dbh}->prepare($query);
     $sth->execute( $dbvar, $fld ) || $self->dberror($query);
 
-    $self->{dbh}->commit if !defined $nocommit;
-
     return $var;
 }
 

Modified: trunk/LedgerSMB/GL.pm
===================================================================
--- trunk/LedgerSMB/GL.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/GL.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -239,10 +239,6 @@
 
     $form->save_recurring( $dbh, $myconfig );
 
-    # commit and redirect
-    my $rc = $dbh->commit;
-
-    $rc;
 }
 
 sub transaction {
@@ -354,8 +350,6 @@
     # get projects
     $form->all_business_units( $form->{transdate} );
 
-    $dbh->commit;
-
 }
 
 

Modified: trunk/LedgerSMB/IC.pm
===================================================================
--- trunk/LedgerSMB/IC.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/IC.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -249,9 +249,8 @@
 
 sub save {
     my ( $self, $myconfig, $form ) = @_;
-    my $nocommit=1;
     $form->{partnumber} =
-      $form->update_defaults( $myconfig, "partnumber", $dbh,$nocommit)
+      $form->update_defaults( $myconfig, "partnumber", $dbh)
       if $form->should_update_defaults('partnumber');
 
     ( $form->{inventory_accno} ) = split( /--/, $form->{IC_inventory} );
@@ -613,7 +612,6 @@
         }
     }
 
-    my $rc = $dbh->commit;
 
     $form->run_custom_queries( 'parts', 'UPDATE' );
     $rc;
@@ -798,7 +796,6 @@
     }
     $sth->finish;
 
-    $dbh->commit;
 
 }
 
@@ -818,9 +815,8 @@
 
     }
 
-    my $rc = $dbh->commit;
 
-    $rc;
+    1;
 
 }
 
@@ -905,10 +901,8 @@
     $sth   = $dbh->prepare($query);
     $sth->execute( $form->{id} ) || $form->dberror($query);
 
-    # commit
-    my $rc = $dbh->commit;
 
-    $rc;
+    1;
 
 }
 
@@ -1098,7 +1092,6 @@
         $sth->finish;
     }
 
-    $dbh->commit;
 
 }
 
@@ -1117,7 +1110,6 @@
     }
     $sth->finish;
 
-    $dbh->commit;
 
 }
 

Modified: trunk/LedgerSMB/IR.pm
===================================================================
--- trunk/LedgerSMB/IR.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/IR.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -831,9 +831,7 @@
 			 WHERE id = $item|;
         $dbh->do($query) || $form->dberror($query);
     }
-    my $rc = $dbh->commit;
 
-    $rc;
 
 }
 
@@ -972,8 +970,6 @@
     $sth = $dbh->prepare($query);
     $sth->execute( $form->{id} ) || $form->dberror($query);
 
-    #$dbh->commit;#tshvr lower-level sub should not commit on behalf of higher-level sub
-
 }
 
 sub retrieve_invoice {
@@ -1205,10 +1201,7 @@
 
     }
 
-    my $rc = $dbh->commit;
 
-    $rc;
-
 }
 
 sub retrieve_item {
@@ -1533,7 +1526,6 @@
           $sth->execute($invoice_id,$report) || $form->dberror("$query");
    }
 
-   #$dbh->commit();#tshvr lower-level sub should not commit on behalf of higher-level sub
 
 }
 

Modified: trunk/LedgerSMB/OE.pm
===================================================================
--- trunk/LedgerSMB/OE.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/OE.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -94,7 +94,7 @@
         "currency",  "department_id", "employee_id",   "language_code",
         "ponumber",  "terms"
     );
-    # connect to database, turn off autocommit
+
     my $dbh = $form->{dbh};
     my $b_unit_sth = $dbh->prepare(
          "INSERT INTO business_unit_oitem (entry_id, class_id, bu_id)
@@ -497,11 +497,6 @@
         id       => $form->{id}
     );
 
-   # $form->audittrail( $dbh, "", \%audittrail );
-
-    my $rc = $dbh->commit;
-
-    $rc;
 }
 
 sub delete {
@@ -583,15 +578,11 @@
 
     $form->audittrail( $dbh, "", \%audittrail );
 
-    my $rc = $dbh->commit;
 
-    if ($rc) {
-        foreach $spoolfile (@spoolfiles) {
-            unlink "${LedgerSMB::Sysconfig::spool}/$spoolfile" if $spoolfile;
-        }
+    foreach $spoolfile (@spoolfiles) {
+        unlink "${LedgerSMB::Sysconfig::spool}/$spoolfile" if $spoolfile;
     }
 
-    $rc;
 
 }
 
@@ -796,7 +787,6 @@
 
     }
 
-    $dbh->commit;
 
 }
 
@@ -1450,7 +1440,6 @@
 		 WHERE setting_key = 'weightunit'|;
     ( $form->{weightunit} ) = $dbh->selectrow_array($query);
 
-    $dbh->commit;
 
 }
 
@@ -1755,10 +1744,6 @@
         }
     }
 
-    my $rc = $dbh->commit;
-
-    $rc;
-
 }
 
 sub adj_onhand {
@@ -1980,7 +1965,6 @@
     }
     $sth->finish;
 
-    $dbh->commit;
 }
 
 sub transfer {
@@ -2033,10 +2017,6 @@
         }
     }
 
-    my $rc = $dbh->commit;
-
-    $rc;
-
 }
 
 sub get_soparts {
@@ -2078,8 +2058,6 @@
     # foreign exchange rates
     &exchangerate_defaults( $dbh, $form );
 
-    $dbh->commit;
-
 }
 
 sub add_items_required {
@@ -2334,10 +2312,6 @@
 
     }
 
-    my $rc = $dbh->commit;
-
-    $rc;
-
 }
 
 1;

Modified: trunk/LedgerSMB/Session.pm
===================================================================
--- trunk/LedgerSMB/Session.pm	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/LedgerSMB/Session.pm	2014-01-06 07:53:06 UTC (rev 6401)
@@ -70,7 +70,6 @@
     my $sessionValid = $checkQuery->fetchrow_hashref('NAME_lc');
     my ($session_ref) = $sessionValid;
     $sessionValid = $sessionValid->{session_id};
-    $dbh->commit;
 
     if ($sessionValid) {
        
@@ -221,7 +220,6 @@
     }
     print qq|Set-Cookie: ${LedgerSMB::Sysconfig::cookie_name}=$newCookieValue; path=$path;$secure\n|;
     $lsmb->{LedgerSMB} = $newCookieValue;
-    $lsmb->{dbh}->commit;
 }
 
 =item destroy

Modified: trunk/lsmb-request.pl
===================================================================
--- trunk/lsmb-request.pl	2014-01-06 07:36:36 UTC (rev 6400)
+++ trunk/lsmb-request.pl	2014-01-06 07:53:06 UTC (rev 6401)
@@ -106,6 +106,7 @@
     $script->can($request->{action}) 
       || die $locale->text("Action Not Defined: ") . $request->{action};
     $script->can( $request->{action} )->($request);
+    $request->{dbh}->commit if defined $request->{dbh};
     LedgerSMB::App_State->cleanup();
   }
   catch {

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ledger-smb-commits mailing list
..hidden..
https://lists.sourceforge.net/lists/listinfo/ledger-smb-commits