[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

SF.net SVN: ledger-smb:[5471] trunk



Revision: 5471
          http://ledger-smb.svn.sourceforge.net/ledger-smb/?rev=5471&view=rev
Author:   einhverfr
Date:     2013-01-04 09:15:16 +0000 (Fri, 04 Jan 2013)
Log Message:
-----------
POD coverage tests much expanded, all passing

Modified Paths:
--------------
    trunk/LedgerSMB/Report/Contact/History.pm
    trunk/LedgerSMB/Report/PNL/ECA.pm
    trunk/LedgerSMB/Scripts/asset.pm
    trunk/LedgerSMB/Scripts/employee.pm
    trunk/LedgerSMB/Scripts/lreports_co.pm
    trunk/LedgerSMB/Scripts/menu.pm
    trunk/LedgerSMB/Scripts/payment.pm
    trunk/LedgerSMB/Scripts/recon.pm
    trunk/LedgerSMB/Scripts/transtemplate.pm
    trunk/LedgerSMB/Scripts/user.pm
    trunk/LedgerSMB/Scripts/vouchers.pm
    trunk/LedgerSMB/Template/CSV.pm
    trunk/t/98-pod-coverage.t

Modified: trunk/LedgerSMB/Report/Contact/History.pm
===================================================================
--- trunk/LedgerSMB/Report/Contact/History.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Report/Contact/History.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -28,6 +28,7 @@
 use Moose;
 extends 'LedgerSMB::Report';
 use LedgerSMB::PGDate;
+use LedgerSMB::Moosetypes;
 
 =head1 PROPERTIES
 
@@ -234,7 +235,7 @@
 
 =cut
 
-has from_date => (is => 'ro', coerce => 1, isa => 'LedgerSMB::DBObject::Date');
+has from_date => (is => 'ro', coerce => 1, isa => 'LedgerSMB::Moose::Date');
 
 =item to_date
 
@@ -242,7 +243,7 @@
 
 =cut
 
-has to_date => (is => 'ro', coerce => 1, isa => 'LedgerSMB::DBObject::Date');
+has to_date => (is => 'ro', coerce => 1, isa => 'LedgerSMB::Moose::Date');
 
 =item type
 

Modified: trunk/LedgerSMB/Report/PNL/ECA.pm
===================================================================
--- trunk/LedgerSMB/Report/PNL/ECA.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Report/PNL/ECA.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -37,13 +37,13 @@
 
 has id => (is => 'rw', isa =>'Int');
 
-=item name 
+=item legal_name 
 
 Name of the customer
 
 =cut
 
-has 'name' => (is => 'rw', isa =>'Str'); 
+has 'legal_name' => (is => 'rw', isa =>'Str'); 
 
 =item meta_number
 

Modified: trunk/LedgerSMB/Scripts/asset.pm
===================================================================
--- trunk/LedgerSMB/Scripts/asset.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/asset.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -126,8 +126,12 @@
     asset_category_screen($ac);
 }
 
-# Is this even working at the moment?  Not documenting unil I know.
+=item asset_category_search
 
+Displays the asset category search screen
+
+=cut
+
 sub asset_category_search {
     my ($request) = @_;
     my $template = LedgerSMB::Template->new(
@@ -234,7 +238,7 @@
     asset_screen($asset);
 }
 
-=item
+=item asset_screen
 
 Screen to create a new asset.
 
@@ -971,20 +975,6 @@
 
 }
 
-# I don't believe this is used,  Not documenting for now. --CT
-
-sub begin_nbv {
-    my ($request) = @_;
-    my $template = LedgerSMB::Template->new(
-        user =>$request->{_user}, 
-        locale => $request->{_locale},
-        path => 'UI/asset',
-        template => 'nbv_filter',
-        format => 'HTML'
-    );
-    $template->render($request);
-}
-
 =item display_nbv
 
 Displays the net book value report, namely the current net value of all active

Modified: trunk/LedgerSMB/Scripts/employee.pm
===================================================================
--- trunk/LedgerSMB/Scripts/employee.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/employee.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -394,7 +394,7 @@
     get($request);
 }
 
-=item delete_bank_acct
+=item delete_bank_account
 
 Deletes the selected bank account record
 

Modified: trunk/LedgerSMB/Scripts/lreports_co.pm
===================================================================
--- trunk/LedgerSMB/Scripts/lreports_co.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/lreports_co.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -23,7 +23,7 @@
 
 =over
 
-=item begin_caja_diaria
+=item start_caja_diaria
 
 Displays the filter screen for Caja Diaria
 
@@ -41,7 +41,7 @@
     $template->render($request);
 }
 
-=item begin_bm
+=item start_bm
 
 Displays the filter screen for Balance y Mayor
 

Modified: trunk/LedgerSMB/Scripts/menu.pm
===================================================================
--- trunk/LedgerSMB/Scripts/menu.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/menu.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -138,7 +138,7 @@
 
 =over
 
-=item drillown_menu
+=item drilldown_menu
 
 This function creates a single cross section of the menu.  Currently this is
 most useful for generating menus for small screen devices or devices where a

Modified: trunk/LedgerSMB/Scripts/payment.pm
===================================================================
--- trunk/LedgerSMB/Scripts/payment.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/payment.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -70,7 +70,7 @@
 
 =over
 
-=item payment
+=item payments
 
 This method is used to set the filter screen and prints it, using the 
 TT2 system.

Modified: trunk/LedgerSMB/Scripts/recon.pm
===================================================================
--- trunk/LedgerSMB/Scripts/recon.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/recon.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -44,7 +44,7 @@
 
 =item search($self, $request, $user)
 
-Renders out a list of meta-reports based on the search criteria passed to the
+Renders out a list of reports based on the search criteria passed to the
 search function.
 Meta-reports are report_id, date_range, and likely errors.
 Search criteria accepted are 
@@ -61,6 +61,11 @@
 
 =back
 
+=item update_recon_set
+
+Updates the reconciliation set, checks for new transactions to be included,
+and re-renders the reconciliation screen.
+
 =cut
 
 sub update_recon_set {
@@ -369,7 +374,7 @@
     
 }
 
-=item ($request)
+=item delete_report($request)
 
 Requires report_id
 

Modified: trunk/LedgerSMB/Scripts/transtemplate.pm
===================================================================
--- trunk/LedgerSMB/Scripts/transtemplate.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/transtemplate.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -1,9 +1,28 @@
+=head1 NAME
 
+LedgerSMB::Scripts::transtemplate - Transaction Template Workflows for LedgerSMB
+
+=head1 SYNPOSIS
+
+ LedgerSMB::Scripts::transtemplate::view($request);
+
+=cut 
+
 package LedgerSMB::Scripts::transtemplate;
 use LedgerSMB::DBObject::TransTemplate;
 use LedgerSMB::Template;
 our $VERSION = '0.1';
 
+=head1 ROUTINES
+
+=over
+
+=item view
+
+Views the transaction template.  Requires that id be set.
+
+=cut
+
 sub view {
     my $request = shift @_;
     use LedgerSMB::Form;
@@ -45,6 +64,13 @@
 
 }
 
+=item convert_to_form
+
+largely private function designed to convert the request object to a Form 
+object for old code.
+
+=cut
+
 sub convert_to_form{
     my ($trans, $form, $type) = @_;
     if ($type eq 'gl'){
@@ -78,6 +104,12 @@
         }
     }
 }
+
+=item search
+
+Displays transaction template filter
+
+=cut
    
 sub search {
     my ($request) = @_;
@@ -91,6 +123,12 @@
    $template->render($request);
 }
 
+=item display_results
+
+Displays a list of template transactions
+
+=cut
+
 sub display_results {
     my ($request) = @_;
     my $transtemplate = LedgerSMB::DBObject::TransTemplate->new(base => $request);
@@ -141,4 +179,15 @@
       form    => $request,
    });
 }
+
+=back
+
+=head1 COPYRIGHT
+
+COPYRIGHT (C) 2012 The LedgerSMB Core Team.  This file may be re-used under the
+terms of the LedgerSMB General Public License version 2 or at your option any
+later version.  Please see enclosed LICENSE file for details.
+
+=cut
+
 1;

Modified: trunk/LedgerSMB/Scripts/user.pm
===================================================================
--- trunk/LedgerSMB/Scripts/user.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/user.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -31,7 +31,7 @@
 
 my $slash = "::";
 
-=item preferences_screen
+=item preference_screen
 
 Displays the preferences screen.  No inputs needed.
 

Modified: trunk/LedgerSMB/Scripts/vouchers.pm
===================================================================
--- trunk/LedgerSMB/Scripts/vouchers.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Scripts/vouchers.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -2,9 +2,9 @@
 LedgerSMB::Scripts::vouchers
 
 =head1 SYNPOSIS
-Voucher workflow scripts.
 
-#      --CT
+ LedgerSMB::Scripts::vouchers::delete_batch($request);
+
 =head1 METHODS
 
 =over
@@ -72,7 +72,7 @@
     $template->render($batch);
 }
 
-=item create-vouchers
+=item create_vouchers
 
 Closes the form in the db, and if unsuccessful displays the batch info again.
 
@@ -94,6 +94,7 @@
         create_batch($request);
     }
 }
+
 =item add_vouchers
 
 Redirects to a script to add vouchers for the type.  batch_type must be set.
@@ -225,20 +226,6 @@
     $report->render($request);
 }
 
-# alias for batch_delete, needed for form-dynatable
-sub list_batches_batch_delete {
-    batch_delete(@_);
-}
-
-sub get_batch_batch_delete {
-    batch_delete(@_);
-}
-
-# alias for batch_post, needed for form-dynatable
-sub list_batches_batch_approve {
-    batch_approve(@_);
-}
-
 =item get_batch_batch_approve
 
 Approves the single batch on the details screen.  Batch_id must be set.,

Modified: trunk/LedgerSMB/Template/CSV.pm
===================================================================
--- trunk/LedgerSMB/Template/CSV.pm	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/LedgerSMB/Template/CSV.pm	2013-01-04 09:15:16 UTC (rev 5471)
@@ -19,6 +19,10 @@
 
 Processes the template for text.
 
+=item escape ($var)
+
+Escapes the variable for CSV inclusion
+
 =item postprocess ($parent)
 
 Returns the output filename.

Modified: trunk/t/98-pod-coverage.t
===================================================================
--- trunk/t/98-pod-coverage.t	2013-01-04 08:28:16 UTC (rev 5470)
+++ trunk/t/98-pod-coverage.t	2013-01-04 09:15:16 UTC (rev 5471)
@@ -13,14 +13,13 @@
 if ($@){
     plan skip_all => "Test::Pod::Coverage required for testing POD coverage";
 } else {
-    plan tests => 29;
+    plan tests => 67;
 }
 pod_coverage_ok("LedgerSMB");
 pod_coverage_ok("LedgerSMB::Form");
 pod_coverage_ok("LedgerSMB::AM");
 pod_coverage_ok("LedgerSMB::Database");
 pod_coverage_ok("LedgerSMB::Locale");
-pod_coverage_ok("LedgerSMB::Log");
 pod_coverage_ok("LedgerSMB::Mailer");
 pod_coverage_ok("LedgerSMB::Template");
 pod_coverage_ok("LedgerSMB::Template::CSV");
@@ -34,8 +33,50 @@
 pod_coverage_ok("LedgerSMB::Company_Config");
 pod_coverage_ok("LedgerSMB::DBObject::Admin");
 pod_coverage_ok("LedgerSMB::Scripts::contact");
+pod_coverage_ok("LedgerSMB::Scripts::account");
+pod_coverage_ok("LedgerSMB::Scripts::admin");
+pod_coverage_ok("LedgerSMB::Scripts::asset");
+pod_coverage_ok("LedgerSMB::Scripts::budget_reports");
+pod_coverage_ok("LedgerSMB::Scripts::budgets");
+pod_coverage_ok("LedgerSMB::Scripts::business_unit");
+pod_coverage_ok("LedgerSMB::Scripts::configuration");
+pod_coverage_ok("LedgerSMB::Scripts::contact");
+pod_coverage_ok("LedgerSMB::Scripts::contact_reports");
+pod_coverage_ok("LedgerSMB::Scripts::drafts");
+pod_coverage_ok("LedgerSMB::Scripts::employee");
+pod_coverage_ok("LedgerSMB::Scripts::file.pm");
+pod_coverage_ok("LedgerSMB::Scripts::goods");
+pod_coverage_ok("LedgerSMB::Scripts::import_csv");
+pod_coverage_ok("LedgerSMB::Scripts::inventory");
+pod_coverage_ok("LedgerSMB::Scripts::invoice");
+pod_coverage_ok("LedgerSMB::Scripts::inv_reports");
+pod_coverage_ok("LedgerSMB::Scripts::journal");
+pod_coverage_ok("LedgerSMB::Scripts::login");
+pod_coverage_ok("LedgerSMB::Scripts::lreports_co");
+pod_coverage_ok("LedgerSMB::Scripts::menu");
+pod_coverage_ok("LedgerSMB::Scripts::order");
+pod_coverage_ok("LedgerSMB::Scripts::payment",
+               {also_private => [qr/^(p\_)/]}
+);
+pod_coverage_ok("LedgerSMB::Scripts::payroll");
+pod_coverage_ok("LedgerSMB::Scripts::pnl");
+pod_coverage_ok("LedgerSMB::Scripts::recon");
+pod_coverage_ok("LedgerSMB::Scripts::report_aging");
+pod_coverage_ok("LedgerSMB::Scripts::reports");
+pod_coverage_ok("LedgerSMB::Scripts::setup");
+pod_coverage_ok("LedgerSMB::Scripts::taxform");
+pod_coverage_ok("LedgerSMB::Scripts::timecard");
+pod_coverage_ok("LedgerSMB::Scripts::transtemplate");
+pod_coverage_ok("LedgerSMB::Scripts::trial_balance");
+pod_coverage_ok("LedgerSMB::Scripts::user");
+pod_coverage_ok("LedgerSMB::Scripts::vouchers");
 pod_coverage_ok("LedgerSMB::Entity::Person::Employee");
 pod_coverage_ok("LedgerSMB::File");
+pod_coverage_ok("LedgerSMB::File::ECA");
+pod_coverage_ok("LedgerSMB::File::Entity");
+pod_coverage_ok("LedgerSMB::File::Order");
+pod_coverage_ok("LedgerSMB::File::Part");
+pod_coverage_ok("LedgerSMB::File::Transaction");
 pod_coverage_ok("LedgerSMB::DBObject");
 pod_coverage_ok("LedgerSMB::Batch");
 pod_coverage_ok("LedgerSMB::DBObject::Payment", 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.