SF.net SVN: ledger-smb:[4255] branches/1.3/sql/modules/Payment.sql

[..hidden..]

Revision: 4255
          http://ledger-smb.svn.sourceforge.net/ledger-smb/?rev=4255&view=rev
Author:   ehuelsmann
Date:     2012-01-08 15:49:48 +0000 (Sun, 08 Jan 2012)
Log Message:
-----------
Payment.sql: some notes on possible bugs.

Modified Paths:
--------------
    branches/1.3/sql/modules/Payment.sql

Modified: branches/1.3/sql/modules/Payment.sql
===================================================================
--- branches/1.3/sql/modules/Payment.sql	2012-01-08 11:32:43 UTC (rev 4254)
+++ branches/1.3/sql/modules/Payment.sql	2012-01-08 15:49:48 UTC (rev 4255)
@@ -542,6 +542,8 @@
 		||$E$ 
 		FROM bulk_payments_in where amount <> 0 $E$;
 
+	-- ### BUG: Where's the FX gain/loss part for FX postings??
+
 	EXECUTE $E$ DROP TABLE bulk_payments_in $E$;
 	perform unlock_all();
 	return out_count;
@@ -658,6 +660,10 @@
        	        trans_id = in_transaction_id[out_count] AND
        	        ( c.link = 'AP' OR c.link = 'AR' );
         -- We need to know the exchangerate of this transaction
+	-- ### BUG: we don't have a guarantee that the transaction is
+	--          the same currency as in_curr, so, we can't use
+	--          current_exchangerate as the basis for fx gain/loss
+	--          calculations
         IF (in_curr = default_currency) THEN 
            old_exchangerate := 1;
         ELSIF (in_account_class = 2) THEN

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.