[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ledgersmb.spec in version 1.4.20



I don't know if this has been discussed here before or not. I haven't red this mailing list for a while and I have never generated an RPM package for ledgersmb before today. So bare with me please.
Anyway, I found a bug in ledgersmb and here it is. First the two chmod fail when they encounter files with space in their names. And second the symbolic link creation I don't know what it is for, so I commented it out. Please let me know if that's a mistake.

Here's a diff:

*** ledgersmb.spec.orig 2015-12-04 14:53:38.754402395 -0500
--- ledgersmb.spec 2015-12-04 14:50:56.402822290 -0500
***************
*** 62,69 ****
  %prep
  %setup -q -n ledgersmb
  
! chmod 0644 $(find . -type f)
! chmod 0755 $(find . -type d)
  chmod +x *.pl
  chmod -x custom.pl # FIXME: Config???
  chmod +x utils/*/*.pl utils/devel/find-use utils/pos/pos-hardware-client-startup-script
--- 62,69 ----
  %prep
  %setup -q -n ledgersmb
  
! find . -type f -exec chmod 0644 {} \;
! find . -type d -exec chmod 0755 {} \;
  chmod +x *.pl
  chmod -x custom.pl # FIXME: Config???
  chmod +x utils/*/*.pl utils/devel/find-use utils/pos/pos-hardware-client-startup-script
***************
*** 141,147 ****
  install -m 644 rpm-ledgersmb-httpd.conf \
    $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d/ledgersmb.conf
  
! ln -s /usr/share/dojo $RPM_BUILD_ROOT%{_datadir}/%{name}/UI/lib/dojo
  
  %clean
  rm -rf $RPM_BUILD_ROOT
--- 141,147 ----
  install -m 644 rpm-ledgersmb-httpd.conf \
    $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d/ledgersmb.conf
  
! #ln -s /usr/share/dojo $RPM_BUILD_ROOT%{_datadir}/%{name}/UI/lib/dojo
  
  %clean
  rm -rf $RPM_BUILD_ROOT

Khalil FOUNDY
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________
Ledger-smb-users mailing list
..hidden..
https://lists.sourceforge.net/lists/listinfo/ledger-smb-users