[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How do I run the makefile code - DOES NOT MAKE SENSE



On 17/10/12 15:00, Chris Travers wrote:


On Wed, Oct 17, 2012 at 1:58 AM, Kevin Bailey <..hidden..> wrote:
On 17/10/12 06:41, Chris Travers wrote:


On Tue, Oct 16, 2012 at 10:06 PM, Kevin Bailey <..hidden..> wrote:
How do I run the makefile code?

Should it be run as root?

Should I cd into the base directory of the LS files first?

Probably best to run it as root since it means installing the dependencies.

Also it is best to avoid "make install" for 1.3, since it means running make install on every minor upgrade.  In trunk (1.4), make install is supported for some types of installations.

But the INSTALL file which comes with this 1.3 file says to run:

 $ perl Makefile.PL                                                                                                                                   
 $ make install

So what do you mean - probably best not to run "make install"?

This probably gets chalked up to a preferences thing, and I suppose in some installations it's the best move.

What make install does is copy the man pages extracted from POD and the Perl modules to system-appropriate directories.  If this is done on every minor update, then this is no problem and it offers the advantage of being able to do things like man LedgerSMB::Form.

On the other hand, the reason for my preference is that by copying the Perl modules, sometimes people forget to run make install on the next time and it doesn't go to the new version on the Perl modules because the old modules are the ones that get run.  Again, not a big deal.  Just one of those things that can impact some deployments, and I personally think that make install on 1.3 causes more problems than it solves.

To be safe I am committing a patch to INSTALL to correct that.


I don't really understand what you've put there because I have no idea how you've implemented the perl modules etc in LS.

What we need here are clear instructions so average users can set the system up.

If we need to run 'make install' after running 'perl Makefile.PL'  then this needs to be explicitly explained.  And if it needs to be run after every upgrade to LS then that needs to be explained as well.

And I'm not even sure what are the other options.  Sounds to me like the 'make install' is needed and if you don't run that then 'perl Makefile.PL' is a waste of time.  But as mentioned, I have very limited experience of perl - all I want is to get LS working.

Regards,

Kevin Bailey