Re: [ledgersmb-devel] What should the process toward merging the MC branch be?

On Fri, Jan 18, 2019 at 3:42 PM Erik Huelsmann <..hidden..> wrote:

Hi,

Over the past weeks, we (on the ledgersmb chat channel) have been working to complete all open tasks related to the "Phase 1" of Multi Currency support. Additionally, we have been testing the schema migration code with a number of real-life databases and fixing issues.

A number of bugs and other findings have been fixed. Pre-migration versus post-migration trial-balance comparisons have been implemented as migration validations.

The branch implements new tests unit tests and BDD tests. The branch implements tests for the schema migration code. The branch has undergone manual testing recently (in addition to the manual testing which happened when the code was written originally).

The question now is how to proceed? Would anybody be prepared to jump in with manual testing of the branch and the migration code? Should we be merging the branch to master and find testers there? Should we be writing more tests on the branch before merging? If so, how many tests are "good enough" before we can merge? Or should we merge and develop tests on master? (Which we should anyway...)

For anybody interested what it is exactly that I'm writing about, check the comparison between the master and master-mc branches: https://github.com/ledgersmb/LedgerSMB/compare/master...master-mc (statistics: 415 commits; 6417 additions, 3514 deletions, 161 affected files; first commit July 19, 2016; last commit: today.)

Regards,

--
Bye,

Erik.

http://efficito.com -- Hosted accounting and ERP.
Robust and Flexible. No vendor lock-in.