[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposal for LedgerSMB 1.5: Refactor and move some utility functionality to CPAN

Hi Chris

Thanks for releasing the code. Some initial feedback, based on the description. I haven't tried the module(s) yet.

Name. Why not Pg::Object and Pg::Object::Simple.
The description leads me to believe that PGObject would be better as a Moose role. Especially "Most developers will want to use more functional modules which add to these functions." and the note about state handling.

PGObject::Simple looks like a class consuming that role.

Just a thought, as I can see that LedgerSMB uses Moose.

Just as an update, I have uploaded PGObject and PGObject::Simple to CPAN. These together are a  nearly complete and generalized eqivalent to DBObject.  What is currently missing is the type registration framework we will need for dates and numeric types.  The code is refactored and the interfaces cleaned up and I have sterted requesting feedback elsewhere.

Best wishes
Chris Travers

------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________ Ledger-smb-devel mailing list ..hidden.. https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel