Re: LedgerSMB 1.3.33-rc1 released

[herman vierendeels <..hidden..>]

Hi Chris,

could i still commit following:
Index: bin/ir.pl
===================================================================
--- bin/ir.pl    (revision 5868)
+++ bin/ir.pl    (working copy)
@@ -39,7 +39,6 @@
 #======================================================================

 use LedgerSMB::IR;
-use LedgerSMB::IS;
 use LedgerSMB::PE;
 use LedgerSMB::Tax;

@@ -1402,8 +1401,8 @@
 sub on_hold {

     if ($form->{id}) {
-
-my $toggled = IS->toggle_on_hold($form);
+    #my $toggled = IS->toggle_on_hold($form);#tshvr4
+    my $toggled = IR->toggle_on_hold($form);#tshvr4

         #&invoice_links(); # is that it?
         &edit(); # it was already IN edit for this to be reached.


Index: LedgerSMB/IR.pm
===================================================================
--- LedgerSMB/IR.pm    (revision 5867)
+++ LedgerSMB/IR.pm    (working copy)
@@ -1584,12 +1584,13 @@
     if ($form->{id}) { # it's an existing (.. probably) invoice.

         my $dbh = $form->{dbh};
-        my $sth = $dbh->prepare("SELECT on_hold from ar where ar.id = ?");
+        #my $sth = $dbh->prepare("SELECT on_hold from ar where ar.id
= ?");#tshvr4
+        my $sth = $dbh->prepare("SELECT on_hold from ap where ap.id = ?");
         $sth->execute($form->{id});
         my $state = $sth->fetchrow_array;
         my $n_s; # new state
-        if ($state[0] == 't') {
-
+        #if ($state[0] == 't') {
+        if ($state) {#tshvr4
             # Turn it off
             $n_s = 'f';

@@ -1597,8 +1598,10 @@
             $n_s = 't';
         }

-        $sth = $dbh->prepare("update ar set on_hold = ?::boolean
where ar.id = ?");
-        my $code = $dbh->execute($ns, $form->{id});
+        #$sth = $dbh->prepare("update ar set on_hold = ?::boolean
where ar.id = ?");#tshvr4
+        $sth = $dbh->prepare("update ap set on_hold = ?::boolean
where ap.id = ?");
+        #my $code = $dbh->execute($ns, $form->{id});#tshvr4
+        my $code = $sth->execute($n_s, $form->{id});#tshvr4

         return 1;


2013/5/26 Chris Travers <..hidden..>:
> Hi everyone;
>
> 1.3.33 rc1 is out.  I have made some changes to the changelog since building
> the tarball but these are documentation changes   No need to reset the
> freeze for release clock for that.
>
> This release corrects another 1.3 regression discovered by John Locke which
> causes issues with check printing where explicit formats are set in the
> template, it removes an extremely annoying misfeature inherited from
> SQL-Ledger where updating the order date will change the customer record,
> and includes a significant number of other fixes.  The complete changelog is
> below.
>
> Best Wishes,
> Chris Travers
>
> Changelog for 1.3.33
> * Fixed <?lsmb YYMMMDD ?> interpolation in settings (Chris T)
> * Fixed Department dropdown ordering and selection (Chris T, 810)
> * Fixed Project dropdown ordering and selection (Chris T, 809)
> * Fixed UI inconsistency re: language dropdown (Chris T, 816)
> * Fixed grants to menus (which can cause problems for submenus (Chris T,
> 820)
> * Fixed tax boxes cannot be all unset (Chris T, 818)
> * Project, serial number, and notes now appear initially (Chris T, 824)
> * Fixed double-counting first date's balance on gl report (Chris T)
> * Fixed user creation failing on some timezones with some datestyles (Chris
> T)
> * Added secondary partnumber ordering to eca history report (Chris T)
> * Fixed default_reportable not respected for invoices (Chris T, 799)
> * Fixed dropdowns not affecting date range in tax reports (Chris T, 811)
> * Added missing taxincluded handling, added script to populate (Chris T,
> 832)
> * Fixed code references stringified on LaTeX templates (Chris T, 843)
> * Orders no longer change customer when changing date (Chris T)
> * Fixed toggling on-hold vendor invoices (Herman V)
>
> Herman V is Herman Vierendeels
> Chris T is Chris Travers
>
>
> ------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>