Re: Internal Server Error saving Purchase Transaction

["Nick Prater" <..hidden..>]

>> I'm using ledgersmb 1.3.20, with Math::BigInt 1.997.
>>
>> This results in an Internal Server Error page when I try to save a
>> Purchase Transaction.

I believe this fixes it:

--- LedgerSMB/AA_old.pm	2012-07-23 10:02:40.249133179 +0100
+++ LedgerSMB/AA.pm	2012-07-23 20:52:38.378514454 +0100
@@ -121,7 +121,7 @@
     my $tax         = 0;
     my $fxtax       = 0;
     my $amount;
-    my $diff;
+    my $diff        = 0;

     my %tax = ();
     my $accno;


In the foreach loop beginning at line 129, $diff is first used, without
initialisation, on line 145. At this point $diff=undef, which leads to an
error in Math::BigInt.

Initialising $diff=0 before the loop (rather than just defining the scope)
resolves this.

Should I be filing this as a bug somewhere, or is posting here sufficient?

Many thanks for the help in tracking this down.

Nick