form->action vs form->nextsub?

[Chris Calef <..hidden..>]

Hi,

This is probably all ancient history by now, but way back between 1.2.17 and 1.2.18 the following change was made to menu.pl:


if ( $form->{action} ) {
    # window title bar, user info
    $form->{titlebar} =
        "LedgerSMB "
      . $locale->text('Version')
      . " $form->{version} - $myconfig{name} - $myconfig{dbname}";

     &{ $form->{action} };
}

changed to:

if ( $form->{action} ) {

    # window title bar, user info
    $form->{titlebar} =
        "LedgerSMB "
      . $locale->text('Version')
      . " $form->{version} - $myconfig{name} - $myconfig{dbname}";

     if (substr($form->{action}, 0, 1) =~ /( |\.)/) {
       &{ $form->{nextsub} };
     } else {
       &{ $form->{action} };
     }
     #&{ $form->{action} };

}

Can anyone tell me what the difference between form action and form nextsub is supposed to be, and why there are two variables for what appears to be the same purpose?  It came to my attention because the assembly page Parts buttons broke in this version due to this change, and we were forced to revert the file back to the earlier method.  I assume this problem has been fixed in lsmb 1.2.x by now, we're still running on .18 at the moment (sorry!) but will be upgrading soon.

Cheers,
Chris Calef