[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: locale nls msgid conventions

On Fri, Oct 14, 2011 at 3:47 AM, herman vierendeels <..hidden..> wrote:

I do not know if this is the right way or place or time to treat this thread.
Please correct me if necessary.

But i would propose to code msgid-strings without formatting characters.
This would make maintenance of  locale/po/ files a lot easier.
Changes could be done when doing maintance . Need not to be changed immediately.

Ordinarily I would prefer to change between major branches, but at this point I suspect that most of these strings are not translated and new in 1.3, and this is still a fairly new branch.  If it's going to be done in a stable branch, I think it should be done sooner rather than later.

for instance

$self->{_locale}->text('Error from Function:')
$self->{_locale}->text('Error from Function') . ':'

<th><?lsmb text('Ending GL Balance:') ?></th>
<th><?lsmb text('Ending GL Balance') ?>:</th>

$form->error($locale->text('Invalid Project Data:')
$form->error($locale->text('Invalid Project Data') . ':'

etc etc

regexp-_expression_ to find such constructs:
grep -Er "text[ ]*\([a-zA-Z0-9 ']*[a-zA-Z0-9 ]*:'\)" ./|grep -v '\.svn'|less


I am pretty sure if I got a patch that would do this soon (within the next month or so) I'd almost certainly accept it, esp, if we are discussing this now.  Not 100% sure how much time I can promise to it right now, but a patch would be credited and quite appreciated, as would any updates to the .po files.

Best Wishes,
Chris Travers