[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

error in taxmodule table



Is the code in LedgerSMB/Tax.pm, where it loads a module based upon a
value in the database (this itself concerns me, btw) new since 1.3.18?

a) I think we need something to catch the case where taxmodule returned
   in invalid and give something other than a 500 error.

b) July 1, 2010, our Provincial Sales Tax was killed (merged into
   the federal Harmonized Sales Tax... VAT).  So I have:

sswbooks=# select * from tax;
 chart_id | rate |     taxnumber     |       validto  | pass | taxmodule_id | 
----------+------+-------------------+----------------+------+--------------+
       64 | 0.07 | 89390 4870 RT0001 | 2006-06-30 0... |    0 |            1 
       64 | 0.06 | 89390 4870 RT0001 | 2007-12-31 0... |    0 |            1 
       64 | 0.05 | 89390 4870 RT0001 | 2010-07-01 0... |    0 |            1 
       64 | 0.13 | 89390 4870 RT0001 | infinity        |    0 |            1 
       12 | 0.08 | 2320              | 2010-07-01 0... |    0 |            1 

(minvalue/maxvalue was null, edited out to fit 77 columns)

chart_id==12 is my "PST" account.
I don't delete it, because it is referenced historically.
But, because there is no valid value, I get an empty table back and it
tries to load LedgerSMB/Taxes/.pm

I tried unchecking the "tax" entry in the drop-down menus in the config
for the chart-of-accounts, but the "Options".. tax box stays set after
saving. 

I'm not sure where init_taxes' argument 2, @taxacounts comes from.

-- 
]       He who is tired of Weird Al is tired of life!           |  firewalls  [
]   Michael Richardson, Sandelman Software Works, Ottawa, ON    |net architect[
] ..hidden.. http://www.sandelman.ottawa.on.ca/ |device driver[
   Kyoto Plus: watch the video <http://www.youtube.com/watch?v=kzx1ycLXQSE>
	               then sign the petition. 



Attachment: pgpXauKyY3Auj.pgp
Description: PGP signature