[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ledgersmb 1.3 bin/aa.pl , I would revert part of commit r5799



yes i committed it


2013/7/13 Erik Huelsmann <..hidden..>:
> hi herman,
>
> Am I correct to think the issue reported below has been handled (by you)?
> The conclusion being that it doesn't  require attention anymore? (and thus
> can be removed from my todo list?)
>
> Bye,
>
> Erik
>
> On Jun 24, 2013 12:59 PM, "herman vierendeels"
> <..hidden..> wrote:
>>
>> In r5799 statement &create_links was added to bin/aa.pl  'sub update'
>> But this makes that AA->get_name is called again from create_links
>> and already user-filled in fields like
>> $form->{AP_amount_1}     $form->{amount_1}     $form->{AP}
>> are overridden again in get_name
>>
>> So i would for the moment comment out statement &create_links in 'sub
>> update' of bin/aa.pl.
>>
>> Maybe statements needed for r5799 from create_links could be put in
>> new separate subroutine and called both from 'sub update' and
>> create_links
>>
>>
>> branches/1.3/bin/aa.pl [r5799] .. [r5800]
>>  sub update {
>>      my $display = shift;
>>      $is_update = 1;
>> +    &create_links;
>>     ....
>> }#end sub update
>>
>> sub create_links {
>> ..
>>  AA->get_name( \%myconfig, \%$form );
>> ...
>> $form->{ $form->{ARAP} } = $form->{"$form->{ARAP}_1"};#set in AA get_name
>> ...
>> }#end create_links
>>
>>
>> AA.pm
>>
>> sub get_name
>> ...
>>  # setup last accounts used for this customer/vendor
>> my $i = 0;
>> ...
>>                 $form->{"$form->{ARAP}_amount_$i"} =
>>                   "$ref->{accno}--$ref->{description}"
>>                   if $ref->{accno};
>> ...
>>                 $form->{ $form->{ARAP} } = $form->{"$form->{ARAP}_1"} =
>>                   "$ref->{accno}--" . "$ref->{description}"
>>                   if $ref->{accno};
>> ....
>> #end AA.pm
>>
>> Thanks
>> Herman
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> Ledger-smb-devel mailing list
>> ..hidden..
>> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>