Re: 1.4 ; db TABLEs invoice,orderitems ; drop field precision ?

[herman vierendeels <..hidden..>]

Hello Chris,

I found following:

hvieren@werkstation1:/downloads/ledgersmb/svn$ find ./ -name
'*.p[lm]'|xargs grep  -i 'precision_'
./LedgerSMB/OE.pm:                $form->{"precision_$i"}
./LedgerSMB/IS.pm:            my $decimalplaces =
($form->{"precision_$i"} > $moneyplaces)
./LedgerSMB/IS.pm:                             ? $form->{"precision_$i"}
./LedgerSMB/IS.pm:                $form->{"sellprice_$i"},
$form->{"precision_$i"},
./LedgerSMB/IR.pm:            $decimalplaces =
($form->{"precision_$i"} > $moneyplaces)
./LedgerSMB/IR.pm:                             ? $form->{"precision_$i"}
./LedgerSMB/IR.pm:                $form->{"precision_$i"},
$form->{"notes_$i"},
./bin/ir.pl:            $form->{"precision_$i"} ||= $dec;
./bin/is.pl:            $form->{"precision_$i"} = $dec;
./bin/io.pl:        $form->{"precision_$i"} ||= $dec;
./bin/io.pl:        $dec =  $form->{"precision_$i"};
./bin/io.pl:            $form->{"precision_$i"} )

But i did not find any code where value of field precision is fetched
from table and used afterwards.
So, i think that field precision is stored in database but never used
afterwards.
And my question, when value from db is never used, should it be stored then?

Best Wishes,
Herman


2012/2/2 Chris Travers <..hidden..>:
>
>
> On Thu, Feb 2, 2012 at 5:02 AM, herman vierendeels
> <..hidden..> wrote:
>>
>> Hello Chris,
>>
>> yes,
>>  precision,decimal_places,still_some_other_names_for_it etc. is used.
>>
>> But the value always comes from ledgersmb.conf  ;  decimal_places : 3
>>  or is derived from user_input
>>
>> Never from stored value in field precision in table.
>
>
> That's incorrect.  Look for "precision_$i"
>
> Best Wishes,
> Chris Travers
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Ledger-smb-devel mailing list
> ..hidden..
> https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
>