SF.net SVN: ledger-smb: [2143] branches/1.2

[..hidden..]

Revision: 2143
          http://ledger-smb.svn.sourceforge.net/ledger-smb/?rev=2143&view=rev
Author:   einhverfr
Date:     2008-05-14 14:16:26 -0700 (Wed, 14 May 2008)

Log Message:
-----------
ar_ap_summary_fix now handles transactions with negative ammounts properly.

Modified Paths:
--------------
    branches/1.2/Changelog
    branches/1.2/doc/release_notes
    branches/1.2/sql/fixes/ar_ap_summary_fix_1.2.14.sql

Modified: branches/1.2/Changelog
===================================================================
--- branches/1.2/Changelog	2008-05-14 16:19:52 UTC (rev 2142)
+++ branches/1.2/Changelog	2008-05-14 21:16:26 UTC (rev 2143)
@@ -1,3 +1,9 @@
+Changelog for 1.2.14
+* Fixed double escaping of tex under some circumstances (Seneca)
+* Added fix for bad summary information in AR/AP transactions (1800065,
+1800069, Chris T)
+* Fixed posting issue behind AR/AP transaction report anomilies (Chris T)
+
 Changelog for 1.2.13
 * Fixed all known implicit cast issues with PostgreSQL 8.3 (Chris T)
 * Fixed Vendor Info Incorrectly Escaped in Check Printing Module(1844159,

Modified: branches/1.2/doc/release_notes
===================================================================
--- branches/1.2/doc/release_notes	2008-05-14 16:19:52 UTC (rev 2142)
+++ branches/1.2/doc/release_notes	2008-05-14 21:16:26 UTC (rev 2143)
@@ -1,5 +1,5 @@
 RELEASE NOTES
-LedgerSMB 1.2.13
+LedgerSMB 1.2.14
 
 
 
@@ -117,6 +117,9 @@
 LedgerSMB's database structure does not handle certain areas properly regarding 
 recurring transactions.  A fix for this issue is in the sql/fixes directory.
 
+3.5: AR/AP Transactions
+LedgerSMB from 1.2.0 through 1.2.13 had a bug which saved incorrect summary information for AR and AP transactions (but not invoices).  A fix for this has been included in sql/fixes and new transactions are not affected as of 1.2.14.
+
 4:  Differences between LedgerSMB and SQL-Ledger(TM)
 
 4.1: Login name restrictions

Modified: branches/1.2/sql/fixes/ar_ap_summary_fix_1.2.14.sql
===================================================================
--- branches/1.2/sql/fixes/ar_ap_summary_fix_1.2.14.sql	2008-05-14 16:19:52 UTC (rev 2142)
+++ branches/1.2/sql/fixes/ar_ap_summary_fix_1.2.14.sql	2008-05-14 21:16:26 UTC (rev 2143)
@@ -2,30 +2,60 @@
 
 UPDATE ap 
 SET netamount = 
-	(select sum(amount) from acc_trans 
-	where trans_id = ap.id 
-		AND ((chart_id IN (select id from chart where link = 'AP')
-			     AND amount > 0)
-			OR (chart_id IN 
-				(select id from chart where link like '%tax%')
+	CASE WHEN amount > 0 THEN -1 *
+		(select sum(amount) from acc_trans 
+		where trans_id = ap.id 
+			AND ((chart_id IN (select id from chart where link = 'AP')
+				     AND amount > 0)
+				OR (chart_id IN 
+					(select id from chart where link like '%tax%')
+				)
 			)
 		)
-	)
+	ELSE
+		-1 *
+		(select sum(amount) from acc_trans 
+		where trans_id = ap.id 
+			AND ((chart_id IN 
+				(select id from chart where link = 'AP')
+				     AND amount < 0)
+				OR (chart_id IN 
+					(select id from chart 
+					where link like '%tax%')
+				)
+			)
+		)
+	END
 WHERE netamount IS NULL;
 
 update ap set datepaid = NULL where paid = 0;
 
 UPDATE ar
-SET netamount = -1 *
-	(select sum(amount) from acc_trans 
-	where trans_id = ar.id 
-		AND ((chart_id IN (select id from chart where link = 'AR')
-			     AND amount < 0)
+SET netamount = 
+	CASE WHEN amount > 0 THEN -1 *
+		(select sum(amount) from acc_trans 
+		where trans_id = ar.id 
+			AND ((chart_id IN 
+				(select id from chart where link = 'AR')
+				     AND amount < 0)
+				OR (chart_id IN 
+					(select id from chart 
+					where link like '%tax%')
+				)
+			)
+		)
+	ELSE 
+		(select sum(amount) from acc_trans 
+		where trans_id = ar.id 
+			AND ((chart_id IN (select id from chart 
+				where link = 'AR')
+				     AND amount > 0)
 			OR (chart_id IN 
 				(select id from chart where link like '%tax%')
+				)
 			)
 		)
-	)
+	END
 WHERE netamount IS NULL;
 
 update ar set datepaid = NULL where paid = 0;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.